Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 453603003: Code generate integration test streams for notifications. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Code generate integration test streams for notifications. When a notification is received from the server, it is checked to verify that its type matches the analysis server API, and then it is dispatched to the proper stream. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39094

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -46 lines) Patch
M pkg/analysis_server/test/integration/integration_test_methods.dart View 5 chunks +483 lines, -0 lines 2 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 7 chunks +18 lines, -40 lines 0 comments Download
M pkg/analysis_server/test/integration/server_domain_int_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 2 chunks +71 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-11 15:27:32 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/453603003/diff/1/pkg/analysis_server/test/integration/integration_test_methods.dart File pkg/analysis_server/test/integration/integration_test_methods.dart (right): https://codereview.chromium.org/453603003/diff/1/pkg/analysis_server/test/integration/integration_test_methods.dart#newcode25 pkg/analysis_server/test/integration/integration_test_methods.dart:25: abstract class InttestMixin { I know it's outside ...
6 years, 4 months ago (2014-08-11 16:47:09 UTC) #2
Paul Berry
Committed patchset #1 manually as r39094 (presubmit successful).
6 years, 4 months ago (2014-08-11 17:34:34 UTC) #3
Paul Berry
6 years, 4 months ago (2014-08-11 17:34:44 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/453603003/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/integration_test_methods.dart (right):

https://codereview.chromium.org/453603003/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/integration_test_methods.dart:25: abstract
class InttestMixin {
On 2014/08/11 16:47:09, Brian Wilkerson wrote:
> I know it's outside the scope of this CL, but what would you think of renaming
> this to "IntegrationTestMixin"?

Sure, will do.

Powered by Google App Engine
This is Rietveld 408576698