Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 45313011: Refactor EventStreamProvider.dart to make flow make more sense. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski
Modified:
7 years, 1 month ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refactor EventStreamProvider.dart to make flow make more sense. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29494

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -540 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +180 lines, -180 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +180 lines, -180 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 4 chunks +180 lines, -180 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrei Mouravski
7 years, 1 month ago (2013-10-29 19:42:37 UTC) #1
blois
Just re-ordering and doc comments, right? (diff doesn't quite capture moves all that well).
7 years, 1 month ago (2013-10-29 20:00:20 UTC) #2
Andrei Mouravski
On 2013/10/29 20:00:20, blois wrote: > Just re-ordering and doc comments, right? > > (diff ...
7 years, 1 month ago (2013-10-29 20:36:36 UTC) #3
blois
lgtm
7 years, 1 month ago (2013-10-29 20:42:16 UTC) #4
Andrei Mouravski
7 years, 1 month ago (2013-10-29 21:19:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698