Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 452933002: Update testing instructions in HACKING.txt. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Update testing instructions in HACKING.txt. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/vmservice/observatory/HACKING.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 4 months ago (2014-08-08 14:12:57 UTC) #1
Cutch
Why is it vmservice and not pkg/observatory?
6 years, 4 months ago (2014-08-08 14:36:48 UTC) #2
koda
On 2014/08/08 14:36:48, Cutch wrote: > Why is it vmservice and not pkg/observatory? I believe ...
6 years, 4 months ago (2014-08-08 14:42:53 UTC) #3
Cutch
lgtm
6 years, 4 months ago (2014-08-08 14:45:40 UTC) #4
koda
6 years, 4 months ago (2014-08-08 17:37:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r39044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698