Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 45293002: Mirror API removals: async invocations, mirrorSystemOf(port), Mirror.mirrors. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
ahe, gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mirror API removals: async invocations, mirrorSystemOf(port), Mirror.mirrors. R=ahe@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=29492

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -190 lines) Patch
M runtime/lib/mirrors_patch.dart View 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/mirrors_patch.dart View 1 2 chunks +1 line, -5 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 5 chunks +1 line, -181 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/mirrors/delegate_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rmacnak
Removes them from the API but leaves the implementations in so uses generate warnings.
7 years, 1 month ago (2013-10-25 20:07:01 UTC) #1
rmacnak
Bump.
7 years, 1 month ago (2013-10-28 16:29:57 UTC) #2
gbracha
lgtm the API change
7 years, 1 month ago (2013-10-28 20:18:45 UTC) #3
ahe
LGTM if it works. https://codereview.chromium.org/45293002/diff/60001/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/45293002/diff/60001/runtime/tests/vm/vm.status#newcode73 runtime/tests/vm/vm.status:73: Please use "StaticWarning" instead of ...
7 years, 1 month ago (2013-10-29 09:38:09 UTC) #4
ahe
https://codereview.chromium.org/45293002/diff/60001/sdk/lib/_internal/lib/mirrors_patch.dart File sdk/lib/_internal/lib/mirrors_patch.dart (right): https://codereview.chromium.org/45293002/diff/60001/sdk/lib/_internal/lib/mirrors_patch.dart#newcode19 sdk/lib/_internal/lib/mirrors_patch.dart:19: On 2013/10/29 09:38:09, ahe wrote: > This shouldn't work. ...
7 years, 1 month ago (2013-10-29 09:46:24 UTC) #5
rmacnak
On 2013/10/29 09:46:24, ahe wrote: > https://codereview.chromium.org/45293002/diff/60001/sdk/lib/_internal/lib/mirrors_patch.dart > File sdk/lib/_internal/lib/mirrors_patch.dart (right): > > https://codereview.chromium.org/45293002/diff/60001/sdk/lib/_internal/lib/mirrors_patch.dart#newcode19 > ...
7 years, 1 month ago (2013-10-29 21:13:54 UTC) #6
rmacnak
7 years, 1 month ago (2013-10-29 21:14:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r29492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698