Issue 452493004: Reapplication of revision 38996 (dart side edits to make CSS Properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452493004: Reapplication of revision 38996 (dart side edits to make CSS Properties (Closed)

Created:
6 years, 4 months ago by Emily Fortuna

Modified:
6 years, 4 months ago

Reviewers:
Leaf

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Reapplication of revision 38996 (dart side edits to make CSS Properties accessible with and without prefixes), with the addition of CSSPropertyNames.in which will be deleted once https://codereview.chromium.org/444453006/ is committed. BUG= Committed: https://code.google.com/p/dart/source/detail?r=38998

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2570 lines, -2146 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	56 chunks	+640 lines, -673 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	56 chunks	+651 lines, -667 lines	0 comments	Download
M	tests/html/cssstyledeclaration_test.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tools/dom/scripts/CSSPropertyNames.in	View	1 chunk	+438 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/css_code_generator.py	View	3 chunks	+156 lines, -130 lines	0 comments	Download
M	tools/dom/scripts/dartdomgenerator.py	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	56 chunks	+655 lines, -675 lines	0 comments	Download

Total messages: 3 (0 generated)

Emily Fortuna

I'm waiting for Terry to add CSSProperties via deps. In the meanwhile, I'm checking in ...

6 years, 4 months ago (2014-08-07 17:20:45 UTC) #1

Emily Fortuna

Committed patchset #1 manually as 38998 (presubmit successful).

6 years, 4 months ago (2014-08-07 17:21:12 UTC) #2

Message was sent while issue was closed.

lgtm