Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 451933002: Tweaks to the injector UI (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
jakemac, dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tweaks to the injector UI BUG=

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -27 lines) Patch
M pkg/polymer/lib/src/build/log_injector.css View 1 5 chunks +25 lines, -7 lines 0 comments Download
M pkg/polymer/lib/src/build/log_injector.dart View 2 chunks +32 lines, -15 lines 1 comment Download
M pkg/polymer/lib/src/build/script_compactor.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/script_compactor_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/451933002/diff/20001/pkg/polymer/lib/src/build/log_injector.dart File pkg/polymer/lib/src/build/log_injector.dart (right): https://codereview.chromium.org/451933002/diff/20001/pkg/polymer/lib/src/build/log_injector.dart#newcode104 pkg/polymer/lib/src/build/log_injector.dart:104: ' <span class="text">${span['text']}</span>''</div>'); in the end, I switch to ...
6 years, 4 months ago (2014-08-08 00:40:45 UTC) #1
Siggi Cherem (dart-lang)
(quick note: other than the comments here, there rest is just what we were tweaking ...
6 years, 4 months ago (2014-08-08 00:41:23 UTC) #2
Siggi Cherem (dart-lang)
oh - and I decided for now to leave the normal font, and we can ...
6 years, 4 months ago (2014-08-08 00:42:57 UTC) #3
dgrove
lgtm
6 years, 4 months ago (2014-08-08 14:55:32 UTC) #4
Siggi Cherem (dart-lang)
submitted in r39039 https://code.google.com/p/dart/source/detail?r=39039
6 years, 4 months ago (2014-08-08 17:57:42 UTC) #5
jakemac
6 years, 4 months ago (2014-08-11 13:49:52 UTC) #6
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/451933002/diff/40001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/log_injector.dart (right):

https://codereview.chromium.org/451933002/diff/40001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/log_injector.dart:93: if (hasLocation)
logHtml.write('<div class="location">');
imo it would be clearer to just put all of this location stuff in an if
statement. It is kind of ugly but clearer whats going on.

Powered by Google App Engine
This is Rietveld 408576698