Issue 451633003: Make Iterable.toSet say that it returns a Set with the same equality as the Iterable's contains met…

Issue 451633003: Make Iterable.toSet say that it returns a Set with the same equality as the Iterable's contains met… (Closed)

Created:
6 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 2 months ago

Reviewers:
Anders Johnsen, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Iterable.toSet say that it returns a Set with the same equality as the Iterable's contains method. Let's consider whether this is really desirable once more. It seems messy, but so does not doing it. R=ajohnsen@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=40893

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -9 lines)			Patch
M	runtime/lib/collection_patch.dart	View		9 chunks	+16 lines, -0 lines	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	1	2 chunks	+13 lines, -4 lines	0 comments	Download
M	sdk/lib/core/iterable.dart	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/451633003/diff/1/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://chromiumcodereview.appspot.com/451633003/diff/1/sdk/lib/core/iterable.dart#newcode177 sdk/lib/core/iterable.dart:177: * The returned `Set` will have a `Set.contains` ...

6 years, 2 months ago (2014-10-02 12:04:17 UTC) #3

Lasse Reichstein Nielsen

Committed patchset #2 (id:20001) manually as 40893 (presubmit successful).

6 years, 2 months ago (2014-10-03 07:43:17 UTC) #4

Lasse Reichstein Nielsen

6 years, 2 months ago (2014-10-06 10:54:58 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/451633003/diff/1/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/451633003/diff/1/sdk/lib/core/iterable.dart#n...
sdk/lib/core/iterable.dart:177: * The returned `Set` will have a `Set.contains`
that return the same result
On 2014/10/02 12:04:17, floitsch wrote:
> Remove this sentence. We don't want to give guarantees.
> 
> (also it would be "return*s*")

Done.

Expand Messages | Collapse Messages