Implement JS_INTERCEPTOR_CONSTANT

JS_INTERCEPTOR_CONSTANT(Type) generates a constant interceptor in Dart code.

Use JS_INTERCEPTOR_CONSTANT(KeyboardEvent) in dart:html to avoid creating a lookup table.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29474

[sra1, 2013-10-26 00:29:49]

https://codereview.chromium.org/45143003/diff/30001/sdk/lib/html/dartium/html...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://codereview.chromium.org/45143003/diff/30001/sdk/lib/html/dartium/html...
sdk/lib/html/dartium/html_dartium.dart:25493: -    if ((blob_OR_source_OR_stream
is MediaStream || blob_OR_source_OR_stream == null)) {
Ignore this - script is slightly nondeterministic

[sra1, 2013-10-29 00:30:57]

ping

[ahe, 2013-10-29 15:23:06]

LGTM, but are you sure you want to remove SendPort?

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3189:
compiler.reportError(node,
You can use reportFatalError to abort immediately. But it is fine to use
reportError as well. This way the compiler can diagnose more errors.

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3190:
MessageKind.WRONG_ARGUMENT_FOR_JS_INTERCEPTOR_CONSTANT);
I'd just use MessageKind.GENERIC for this. Users should never see this message.

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/warnings.dart:1455: static const
MessageKind WRONG_ARGUMENT_FOR_JS_INTERCEPTOR_CONSTANT =
I'd remove this message and use MessageKind.GENERIC.

If you decide to keep this message, move it to line 1303.

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/html/darti...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/html/darti...
sdk/lib/html/dartium/html_dartium.dart:31150: -class SendPortSync {}
What about this?

[sra1, 2013-10-29 18:00:46]

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/warnings.dart:1455: static const
MessageKind WRONG_ARGUMENT_FOR_JS_INTERCEPTOR_CONSTANT =
On 2013/10/29 15:23:07, ahe wrote:
> I'd remove this message and use MessageKind.GENERIC.
> 
> If you decide to keep this message, move it to line 1303.

I decided to keep it since there are multiple references and the GENERIC form
formatted to twice as many lines.

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/html/darti...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://chromiumcodereview.appspot.com/45143003/diff/30001/sdk/lib/html/darti...
sdk/lib/html/dartium/html_dartium.dart:31150: -class SendPortSync {}
On 2013/10/29 15:23:07, ahe wrote:
> What about this?

It mysteriously resolved itself.  I suspect the base for my CL had omitted to
run the generator.

[sra1, 2013-10-29 18:26:57]

Committed patchset #4 manually as r29474 (presubmit successful).

[ngeoffray, 2013-10-29 20:30:17]

I like the change, but:

https://chromiumcodereview.appspot.com/45143003/diff/120001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://chromiumcodereview.appspot.com/45143003/diff/120001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1933:
Set<Node> argumentsToJsInterceptorConstant = null;
This does not look very resolver related... why not doing it as a
post-processing action on the AST?

Also, I always feel nervous about adding state to the resolver.

https://chromiumcodereview.appspot.com/45143003/diff/120001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2637: if
(argumentsToJsInterceptorConstant == null)
Please use braces.

[sra1, 2013-10-30 17:18:17]

https://chromiumcodereview.appspot.com/45143003/diff/120001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://chromiumcodereview.appspot.com/45143003/diff/120001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1933:
Set<Node> argumentsToJsInterceptorConstant = null;
On 2013/10/29 20:30:18, ngeoffray wrote:
> This does not look very resolver related... why not doing it as a
> post-processing action on the AST?

Because it causes more classes to be instantiated, which adds their methods to
the resolver queue, so it has to be during resolution.

> 
> Also, I always feel nervous about adding state to the resolver.

Me too.

The resolver is a set of actions that happen when the arguments are ready.
What makes it hard is that some of the actions are done by control flow
(visitors) and others by ad-hoc implementations of the RETE algorithm
(http://en.wikipedia.org/wiki/Rete_algorithm).

This action needs to be deferred since the arguments can't be forced into the
'ready' state by control flow.

What bothers me about this piece of state is not that there is state or too much
state, but that there is not enough state - implicit is that all dependencies of
the argument expression need to be resolved in order to evaluate the constant. 
There is no representation of the readiness of the resolution state.

It would be tedious and probably memory-hungry to convert all steps to actions
that happen when the inputs are ready, but that might be possible efficiently if
resolution was coded in a language that directly supported both demand-driven
and data-driven computation.

https://chromiumcodereview.appspot.com/45143003/diff/120001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2637: if
(argumentsToJsInterceptorConstant == null)
On 2013/10/29 20:30:18, ngeoffray wrote:
> Please use braces.

I will sneak this into another CL.