Issue 45103002: Deprecate dart:io Platform, replaced by dart:platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45103002: Deprecate dart:io Platform, replaced by dart:platform. (Closed)

Created:
7 years, 1 month ago by Bill Hesse

Modified:
7 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deprecate dart:io Platform, replaced by dart:platform. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29272

Patch Set 2 : Fix dartium failure on path_separator_test. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	sdk/lib/io/platform.dart	View		1 chunk	+15 lines, -1 line	0 comments	Download
	M	tests/lib/platform/path_separator_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/45103002/diff/1/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/45103002/diff/1/sdk/lib/io/platform.dart#newcode7 sdk/lib/io/platform.dart:7: @deprecated Put it just before the class. https://codereview.chromium.org/45103002/diff/1/sdk/lib/io/platform.dart#newcode23 ...

7 years, 1 month ago (2013-10-25 19:04:17 UTC) #2

Bill Hesse

7 years, 1 month ago (2013-10-25 19:31:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29272 (presubmit successful).

Expand Messages | Collapse Messages

Issue 45103002: Deprecate dart:io Platform, replaced by dart:platform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix dartium failure on path_separator_test. #

Messages