Issue 450693005: Eliminate the old non blink code paths from idl generation

Issue 450693005: Eliminate the old non blink code paths from idl generation (Closed)

Created:
6 years, 4 months ago by Leaf

Modified:
6 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Eliminate the old non blink code paths from idl generation During the transition to the dart:html dart:blink split, we needed to support generating the old style and the new style. This CL eliminates the code paths for the old style generation now that they're no longer needed. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=39005

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove DART_USE_BLINK from templates #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -238 lines)			Patch
M	tools/dom/scripts/dartdomgenerator.py	View	1	6 chunks	+5 lines, -12 lines	0 comments	Download
M	tools/dom/scripts/go.sh	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View		10 chunks	+129 lines, -191 lines	0 comments	Download
M	tools/dom/templates/html/dartium/chrome_dartium.darttemplate	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1	4 chunks	+0 lines, -9 lines	0 comments	Download
M	tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/dartium/svg_dartium.darttemplate	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_audio_dartium.darttemplate	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_gl_dartium.darttemplate	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_sql_dartium.darttemplate	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/450693005/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (left): https://codereview.chromium.org/450693005/diff/1/tools/dom/scripts/dartdomgenerator.py#oldcode124 tools/dom/scripts/dartdomgenerator.py:124: 'DART_USE_BLINK' : dart_use_blink}) shall we just delete this key ...

6 years, 4 months ago (2014-08-07 18:35:12 UTC) #2

Leaf

ptal? https://codereview.chromium.org/450693005/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (left): https://codereview.chromium.org/450693005/diff/1/tools/dom/scripts/dartdomgenerator.py#oldcode124 tools/dom/scripts/dartdomgenerator.py:124: 'DART_USE_BLINK' : dart_use_blink}) On 2014/08/07 18:35:11, Emily Fortuna ...

6 years, 4 months ago (2014-08-07 19:38:24 UTC) #3

Leaf

6 years, 4 months ago (2014-08-07 20:04:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 39005 (presubmit successful).

Expand Messages | Collapse Messages