Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 449583003: Fix for opening SDK sources. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -11 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +21 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/src/correction/fix.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_testing/lib/mock_sdk.dart View 5 chunks +33 lines, -7 lines 2 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-06 21:59:49 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/449583003/diff/1/pkg/analysis_testing/lib/mock_sdk.dart File pkg/analysis_testing/lib/mock_sdk.dart (right): https://codereview.chromium.org/449583003/diff/1/pkg/analysis_testing/lib/mock_sdk.dart#newcode73 pkg/analysis_testing/lib/mock_sdk.dart:73: const _MockSdkLibrary('async', '/lib/async/async.dart', ''' If this is the ...
6 years, 4 months ago (2014-08-06 22:07:55 UTC) #2
scheglov
https://codereview.chromium.org/449583003/diff/1/pkg/analysis_testing/lib/mock_sdk.dart File pkg/analysis_testing/lib/mock_sdk.dart (right): https://codereview.chromium.org/449583003/diff/1/pkg/analysis_testing/lib/mock_sdk.dart#newcode73 pkg/analysis_testing/lib/mock_sdk.dart:73: const _MockSdkLibrary('async', '/lib/async/async.dart', ''' On 2014/08/06 22:07:55, Brian Wilkerson ...
6 years, 4 months ago (2014-08-06 22:13:07 UTC) #3
scheglov
6 years, 4 months ago (2014-08-06 22:13:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 38955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698