Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 449263002: Add test for JS_CONST (Closed)

Created:
6 years, 4 months ago by sra1
Modified:
6 years, 4 months ago
Reviewers:
Emily Fortuna, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A tests/compiler/dart2js_native/js_const_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sra1
6 years, 4 months ago (2014-08-07 23:15:54 UTC) #1
floitsch
LGTM.
6 years, 4 months ago (2014-08-15 17:52:18 UTC) #2
floitsch
On 2014/08/15 17:52:18, floitsch wrote: > LGTM. But it would make sense to use the ...
6 years, 4 months ago (2014-08-15 17:53:28 UTC) #3
sra1
Committed patchset #1 manually as 39308 (presubmit successful).
6 years, 4 months ago (2014-08-15 18:33:01 UTC) #4
sra1
6 years, 4 months ago (2014-08-15 18:37:08 UTC) #5
Message was sent while issue was closed.
On 2014/08/15 17:53:28, floitsch wrote:
> On 2014/08/15 17:52:18, floitsch wrote:
> > LGTM.
> 
> But it would make sense to use the result in a const object too:
> 
> class A {
>   final x;
>   const A(this.x);
> }
> 
> main() {
>   var a = const A(JS_CONST(...));
>   Expect.equals(..., a.x);
> }

The test just covers current usage.

I'd like to find some other solution for this since these tests are inconsistent
depending whether optimized by type inference to executed dynamically.

var a = JS_CONST(...);
...
a is JS_CONST
a is JavaScriptObject

Powered by Google App Engine
This is Rietveld 408576698