Support Git in pub global activate.

Support Git in pub global activate.

BUG=https://code.google.com/p/dart/issues/detail?id=19902
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39279

[Bob Nystrom, 2014-08-12 17:23:59]

Friendly ping!

[nweiz, 2014-08-13 02:31:55]

I may have missed it, but I didn't see a test for actually running an executable
from a git package. I'd also like to see a test that re-activating a git package
upgrades it.

https://codereview.chromium.org/448933002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/global_activate.dart (right):

https://codereview.chromium.org/448933002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/global_activate.dart:49: return
globals.activateGit(package, repo);
I really don't think the user should have to specify the package name *and* repo
location. If that means we have to clone the repository into a temporary
location and then move it into the cache, that's worth it.

There should also at least be a TODO here to support choosing the ref to
activate for the package.

[Bob Nystrom, 2014-08-13 22:44:53]

> I may have missed it, but I didn't see a test for actually running an
executable
from a git package.

I didn't bother initially because it's effectively the same code path as hosted
ones. But done.

> I'd also like to see a test that re-activating a git package
upgrades it.

Done!

https://codereview.chromium.org/448933002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/global_activate.dart (right):

https://codereview.chromium.org/448933002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/global_activate.dart:49: return
globals.activateGit(package, repo);
On 2014/08/13 02:31:55, nweiz wrote:
> I really don't think the user should have to specify the package name *and*
repo
> location. If that means we have to clone the repository into a temporary
> location and then move it into the cache, that's worth it.

Done, though I don't move it into the cache. To do that correctly, we'd have to:

1. Mirror it to a temp directory.
2. Clone that to another temp directory (since 1 has no checkout).
3. Get the name.
4. Rename 1 to the canonical repo path.
5. Rename 2 to the repo ID path.

On step 4, if the canonical repo already exists, we don't do the rename. I'm not
sure if we'd need to ditch 2 or if it's still valid. Likewise, on step 5, we
don't do the rename if it turns out that a checkout with that ID already exists.

All of that seems like it would lead to lots of bugs and lots of edge cases that
need lots of tests.

Instead, I just do a shallow clone to a temp dir, read the pubspec, and then
trash it. It ends up doing a redundant clone after that, but I look at that as a
perf problem. Given that pub global activate is rarely used and most git repos
are small, that doesn't bother me.

> There should also at least be a TODO here to support choosing the ref to
> activate for the package.

Done.

[nweiz, 2014-08-14 00:40:54]

lgtm

https://codereview.chromium.org/448933002/diff/30001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/source/git.dart (right):

https://codereview.chromium.org/448933002/diff/30001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/source/git.dart:240: /// remote repository. See
the manpage for `git clone` for more information.
Document [shallow].

[Bob Nystrom, 2014-08-15 00:06:16]

Committed patchset #2 manually as 39279 (presubmit successful).

[Bob Nystrom, 2014-08-15 00:06:41]

https://codereview.chromium.org/448933002/diff/30001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/source/git.dart (right):

https://codereview.chromium.org/448933002/diff/30001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/source/git.dart:240: /// remote repository. See
the manpage for `git clone` for more information.
On 2014/08/14 00:40:54, nweiz wrote:
> Document [shallow].

Done.