Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 448413002: Do regular expression for camelCase CSS processing in JS. (Closed)

Created:
6 years, 4 months ago by Emily Fortuna
Modified:
6 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Do regular expression for camelCase CSS processing in JS. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=39018

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 chunk +8 lines, -0 lines 1 comment Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
6 years, 4 months ago (2014-08-08 00:46:31 UTC) #1
sra1
lgtm https://codereview.chromium.org/448413002/diff/1/tools/dom/scripts/css_code_generator.py File tools/dom/scripts/css_code_generator.py (right): https://codereview.chromium.org/448413002/diff/1/tools/dom/scripts/css_code_generator.py#newcode136 tools/dom/scripts/css_code_generator.py:136: // The "ms" prefix is always lowercased. This ...
6 years, 4 months ago (2014-08-08 00:49:28 UTC) #2
Emily Fortuna
6 years, 4 months ago (2014-08-08 00:50:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698