Issue 446373002: VM: Fix bug in CHA for signature classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 446373002: VM: Fix bug in CHA for signature classes. (Closed)

Created:
6 years, 4 months ago by Florian Schneider

Modified:
6 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix bug in CHA for signature classes. The subclasses for the _FunctionImpl class were not tracked in the VM. As a result, CHA would incorrectly assume that _FunctionImpl does not have any subclasses. This may cause incorrect optimization and caused unnecessary deoptimizations. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38981

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	runtime/vm/cha_test.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	runtime/vm/class_finalizer.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

On 2014/08/07 12:19:46, Vyacheslav Egorov (Google wrote: > LGTM > > Maybe add a test? ...

6 years, 4 months ago (2014-08-07 12:45:56 UTC) #3

Florian Schneider

6 years, 4 months ago (2014-08-07 12:46:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38981 (presubmit successful).

Expand Messages | Collapse Messages