Issue 445733003: Reapply 38999. Third time's the charm! The issue was supportsTransitions was a

Issue 445733003: Reapply 38999. Third time's the charm! The issue was supportsTransitions was a (Closed)

Created:
6 years, 4 months ago by Emily Fortuna

Modified:
6 years, 4 months ago

Reviewers:
Leaf

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply 38999. Third time's the charm! The issue was supportsTransitions was a static method,and with my change I was calling an instance method. I've tested all of the other html tests (before I was just testing on Dartium). BUG= R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=39003

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2570 lines, -2146 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	56 chunks	+640 lines, -673 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	56 chunks	+651 lines, -667 lines	0 comments	Download
M	tests/html/cssstyledeclaration_test.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tools/dom/scripts/CSSPropertyNames.in	View	1 chunk	+438 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/css_code_generator.py	View	3 chunks	+156 lines, -130 lines	1 comment	Download
M	tools/dom/scripts/dartdomgenerator.py	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	56 chunks	+655 lines, -675 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/445733003/diff/1/tools/dom/scripts/css_code_generator.py File tools/dom/scripts/css_code_generator.py (right): https://codereview.chromium.org/445733003/diff/1/tools/dom/scripts/css_code_generator.py#newcode163 tools/dom/scripts/css_code_generator.py:163: return document.body.style.supportsProperty('transition'); this is the one line that is ...

6 years, 4 months ago (2014-08-07 18:22:24 UTC) #1

Emily Fortuna

6 years, 4 months ago (2014-08-07 18:36:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39003 (presubmit successful).

Expand Messages | Collapse Messages