Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 444793002: Report compile time error if const class has non-const initializer (Closed)

Created:
6 years, 4 months ago by hausner
Modified:
6 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Report compile time error if const class has non-const initializer A recent language change requires classes with a const constructor to have compile-time constant field initializer expressions. This CL adds the check, and removes code to handle const instance fields, which do not exist in Dart. Fixes issue 18779. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=38910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/vm/parser.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 4 months ago (2014-08-05 20:47:23 UTC) #1
regis
LGTM
6 years, 4 months ago (2014-08-05 21:24:07 UTC) #2
hausner
6 years, 4 months ago (2014-08-05 21:50:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698