Issue 444293002: Fixes for the 'pub' bot and 'analysis_server' on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444293002: Fixes for the 'pub' bot and 'analysis_server' on Windows. (Closed)

Created:
6 years, 4 months ago by scheglov

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for the 'pub' bot and 'analysis_server' on Windows. TBR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38962

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		3 chunks	+8 lines, -3 lines	1 comment	Download
	M	pkg/analyzer/lib/file_system/memory_file_system.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as 38962 (presubmit successful).

6 years, 4 months ago (2014-08-07 02:02:06 UTC) #2

Brian Wilkerson

6 years, 4 months ago (2014-08-07 14:40:29 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/444293002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/444293002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:207: this, resourceProvider,
packageMapProvider);
We no longer need to pass the resource provider in explicitly because we're
passing in 'this' and can access it indirectly.

Expand Messages | Collapse Messages