Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 443873006: Add analysis server API specification and related tools. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, jwren, scheglov, danrubel
Visibility:
Public.

Description

Add analysis server API specification and related tools. The source for the API specification is in pkg/analysis_server/spec/spec_input.html. This file uses custom HTML elements to declare the machine-readable parts of the specification. The script pkg/analysis_server/spec/generate_files processes that file and creates two output files: - pkg/analysis_server/spec/api.html, the human-readable analysis server spec. - pkg/analysis_server/test/integration/protocol_matchers.dart, which is used by integration tests to check the data returned by the analysis server. R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38937

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+8597 lines, -138 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analysis_server/spec/api.dart View 1 chunk +449 lines, -0 lines 4 comments Download
A pkg/analysis_server/spec/api.html View 1 chunk +2945 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/codegen_matchers.dart View 1 chunk +195 lines, -0 lines 2 comments Download
A pkg/analysis_server/spec/codegen_tools.dart View 1 chunk +272 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/from_html.dart View 1 chunk +485 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/generate_files View 1 chunk +56 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/html_tools.dart View 1 chunk +110 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/spec_input.html View 1 chunk +3034 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/text_formatter.dart View 1 chunk +233 lines, -0 lines 0 comments Download
A pkg/analysis_server/spec/to_html.dart View 1 chunk +528 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 21 chunks +289 lines, -138 lines 3 comments Download

Messages

Total messages: 7 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-06 17:28:40 UTC) #1
Brian Wilkerson
The code LGTM, but I think the structure needs to be changed. According to the ...
6 years, 4 months ago (2014-08-06 18:12:06 UTC) #2
jwren
LGTM This is great! I might have nits later when I see the look of ...
6 years, 4 months ago (2014-08-06 18:12:52 UTC) #3
scheglov
LGTM https://codereview.chromium.org/443873006/diff/1/pkg/analysis_server/spec/api.dart File pkg/analysis_server/spec/api.dart (right): https://codereview.chromium.org/443873006/diff/1/pkg/analysis_server/spec/api.dart#newcode26 pkg/analysis_server/spec/api.dart:26: * Dispatch the given [node] to the visitor. ...
6 years, 4 months ago (2014-08-06 18:20:39 UTC) #4
Paul Berry
On 2014/08/06 18:12:06, Brian Wilkerson wrote: > The code LGTM, but I think the structure ...
6 years, 4 months ago (2014-08-06 18:32:22 UTC) #5
Paul Berry
https://codereview.chromium.org/443873006/diff/1/pkg/analysis_server/spec/api.dart File pkg/analysis_server/spec/api.dart (right): https://codereview.chromium.org/443873006/diff/1/pkg/analysis_server/spec/api.dart#newcode26 pkg/analysis_server/spec/api.dart:26: * Dispatch the given [node] to the visitor. On ...
6 years, 4 months ago (2014-08-06 18:32:43 UTC) #6
Paul Berry
6 years, 4 months ago (2014-08-06 18:34:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r38937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698