Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 44303002: dart:platform | Fix isolate_test on Dartium. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:platform | Fix isolate_test on Dartium. Change lib/platform/isolate_test to use package:expect instead of package:unittest, so spawnFunction will work on Dartium. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29251

Patch Set 1 #

Patch Set 2 : This fix doesn't work - suppress in status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/lib/lib.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
Dartium says it cannot use spawnFunction if a script uses the DOM, and unittest uses ...
7 years, 1 month ago (2013-10-25 13:26:10 UTC) #1
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-25 13:31:41 UTC) #2
Bill Hesse
The fix doesn't work. Using status file instead. PTAL.
7 years, 1 month ago (2013-10-25 13:41:04 UTC) #3
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-25 13:41:30 UTC) #4
Bill Hesse
7 years, 1 month ago (2013-10-25 13:42:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698