Issue 442693002: Special case substring(0, length) to return itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 442693002: Special case substring(0, length) to return itself. (Closed)

Created:
6 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 4 months ago

Reviewers:
Anders Johnsen, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Special case substring(0, length) to return itself. R=ajohnsen@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38919

Patch Set 2 : Adding parentheses. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/lib/string_patch.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm, but wait for srdjan@s accept as well. https://codereview.chromium.org/442693002/diff/1/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/442693002/diff/1/runtime/lib/string_patch.dart#newcode250 runtime/lib/string_patch.dart:250: if ...

6 years, 4 months ago (2014-08-05 08:59:26 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/442693002/diff/1/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/442693002/diff/1/runtime/lib/string_patch.dart#newcode250 runtime/lib/string_patch.dart:250: if (startIndex == 0 && endIndex == this.length) { ...

6 years, 4 months ago (2014-08-05 09:26:56 UTC) #3

Lasse Reichstein Nielsen

6 years, 4 months ago (2014-08-06 07:01:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 38919 (presubmit successful).

Expand Messages | Collapse Messages

Issue 442693002: Special case substring(0, length) to return itself. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Adding parentheses. #

Messages