Issue 44263003: co19-roll to r641

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44263003: co19-roll to r641 (Closed)

Created:
7 years, 1 month ago by kustermann

Modified:
7 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -39 lines)			Patch
M	dart/pkg/pkg.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/co19/co19-analyzer.status	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	dart/tests/co19/co19-analyzer2.status	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	dart/tests/co19/co19-co19.status	View	1	6 chunks	+22 lines, -4 lines	0 comments	Download
M	dart/tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View		6 chunks	+13 lines, -9 lines	0 comments	Download
M	dart/tests/co19/co19-dartium.status	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	dart/tools/testing/dart/co19_test.dart	View	1	1 chunk	+10 lines, -10 lines	0 comments	Download
M	deps/all.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	deps/clank.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	deps/dartium.deps/DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	deps/standalone.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

kustermann

I still need to run none-dartium tests which might bring up new issues.

7 years, 1 month ago (2013-10-25 14:27:58 UTC) #1

ricow1

LGTM - although you are adding more lines than you remove :-)

7 years, 1 month ago (2013-10-25 14:31:29 UTC) #2

kustermann

7 years, 1 month ago (2013-10-25 15:07:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29255 (presubmit successful).