Issue 441903003: Clean up socket:connect change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441903003: Clean up socket:connect change. (Closed)

Created:
6 years, 4 months ago by Anders Johnsen

Modified:
6 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up socket:connect change. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=38918

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	runtime/bin/socket_patch.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	sdk/lib/io/socket.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/441903003/diff/1/sdk/lib/io/socket.dart File sdk/lib/io/socket.dart (right): https://codereview.chromium.org/441903003/diff/1/sdk/lib/io/socket.dart#newcode548 sdk/lib/io/socket.dart:548: * returned. */ */ on new line.

6 years, 4 months ago (2014-08-05 10:24:14 UTC) #2

Anders Johnsen

https://codereview.chromium.org/441903003/diff/1/sdk/lib/io/socket.dart File sdk/lib/io/socket.dart (right): https://codereview.chromium.org/441903003/diff/1/sdk/lib/io/socket.dart#newcode548 sdk/lib/io/socket.dart:548: * returned. */ On 2014/08/05 10:24:14, Søren Gjesse wrote: ...

6 years, 4 months ago (2014-08-06 05:10:32 UTC) #3

Anders Johnsen

6 years, 4 months ago (2014-08-06 05:10:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 38918 (presubmit successful).

Expand Messages | Collapse Messages

Issue 441903003: Clean up socket:connect change. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages