Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 441483004: pkg/watcher: prepare for 0.9.3 (Closed)

Created:
6 years, 4 months ago by kevmoo
Modified:
6 years, 4 months ago
Reviewers:
nweiz, Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/watcher: prepare for 0.9.3 added changelog updated pubspec code formatting removed unused imports R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=38862

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : windows tweaks #

Patch Set 4 : reverting windows tweaks #

Total comments: 2

Patch Set 5 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
A pkg/watcher/CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/watcher/example/watch.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/watcher/lib/src/async_queue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/lib/src/constructable_file_system_event.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/watcher/lib/src/utils.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/watcher/lib/src/watch_event.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/pubspec.yaml View 1 chunk +7 lines, -7 lines 1 comment Download
M pkg/watcher/test/directory_watcher/linux_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/test/directory_watcher/mac_os_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/test/directory_watcher/polling_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/test/directory_watcher/shared.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/test/directory_watcher/windows_test.dart View 1 3 3 chunks +1 line, -3 lines 0 comments Download
M pkg/watcher/test/no_subscription/linux_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/watcher/test/no_subscription/mac_os_test.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/watcher/test/no_subscription/polling_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/watcher/test/no_subscription/shared.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/watcher/test/ready/linux_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/watcher/test/ready/mac_os_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/watcher/test/ready/polling_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/watcher/test/ready/shared.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/test/utils.dart View 5 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevmoo
We've gone back and forth a lot of this. Can we land what we have ...
6 years, 4 months ago (2014-08-02 18:59:50 UTC) #1
Anders Johnsen
lgtm (but please wait for https://codereview.chromium.org/428493004/ to land - you are more than welcome to ...
6 years, 4 months ago (2014-08-04 06:59:58 UTC) #2
kevmoo
Committed patchset #5 manually as 38862 (presubmit successful).
6 years, 4 months ago (2014-08-04 15:55:16 UTC) #3
kevmoo
https://codereview.chromium.org/441483004/diff/2/pkg/watcher/test/directory_watcher/linux_test.dart File pkg/watcher/test/directory_watcher/linux_test.dart (right): https://codereview.chromium.org/441483004/diff/2/pkg/watcher/test/directory_watcher/linux_test.dart#newcode12 pkg/watcher/test/directory_watcher/linux_test.dart:12: void main() { On 2014/08/04 06:59:58, Anders Johnsen wrote: ...
6 years, 4 months ago (2014-08-04 16:06:01 UTC) #4
nweiz
https://codereview.chromium.org/441483004/diff/60001/pkg/watcher/pubspec.yaml File pkg/watcher/pubspec.yaml (right): https://codereview.chromium.org/441483004/diff/60001/pkg/watcher/pubspec.yaml#newcode9 pkg/watcher/pubspec.yaml:9: sdk: '>=1.0.0 <2.0.0' Is this constraint accurate? There were ...
6 years, 4 months ago (2014-08-04 17:48:41 UTC) #5
kevmoo
6 years, 4 months ago (2014-08-08 21:57:06 UTC) #6
Message was sent while issue was closed.
On 2014/08/04 17:48:41, nweiz wrote:
> https://codereview.chromium.org/441483004/diff/60001/pkg/watcher/pubspec.yaml
> File pkg/watcher/pubspec.yaml (right):
> 
>
https://codereview.chromium.org/441483004/diff/60001/pkg/watcher/pubspec.yaml...
> pkg/watcher/pubspec.yaml:9: sdk: '>=1.0.0 <2.0.0'
> Is this constraint accurate? There were a number of workarounds in this code
for
> bugs in earlier versions of dart:io's [Directory.watch] that have since been
> removed as the bugs were fixed.

Added a bug to track this: https://code.google.com/p/dart/issues/detail?id=20434

I'm not sure how to determine what the new min should be. There were a number of
CLS + reverts to watcher recently, but the net result was no change to the
pubspec min version.

Powered by Google App Engine
This is Rietveld 408576698