Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 441063002: Change description in analysis_server pubspec to no longer reference web sockets (Closed)

Created:
6 years, 4 months ago by jwren
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, Brian Wilkerson, scheglov
Visibility:
Public.

Description

Change description in analysis_server pubspec to no longer reference web sockets R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=38903

Patch Set 1 #

Total comments: 1

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jwren
6 years, 4 months ago (2014-08-05 20:42:27 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/441063002/diff/1/pkg/analysis_server/pubspec.yaml File pkg/analysis_server/pubspec.yaml (right): https://codereview.chromium.org/441063002/diff/1/pkg/analysis_server/pubspec.yaml#newcode4 pkg/analysis_server/pubspec.yaml:4: description: A client-server that performs analysis of Dart ...
6 years, 4 months ago (2014-08-05 20:44:13 UTC) #2
jwren
On 2014/08/05 20:44:13, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/441063002/diff/1/pkg/analysis_server/pubspec.yaml > File pkg/analysis_server/pubspec.yaml (right): ...
6 years, 4 months ago (2014-08-05 20:45:37 UTC) #3
jwren
6 years, 4 months ago (2014-08-05 20:47:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 38903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698