Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 440743002: Update 'analysis.override' notification to the latest spec. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Update 'analysis.override' notification to the latest spec. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -83 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 2 chunks +66 lines, -41 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 17 chunks +36 lines, -40 lines 0 comments Download
M pkg/analysis_services/lib/constants.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-08-04 21:15:58 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-04 21:18:58 UTC) #2
scheglov
6 years, 4 months ago (2014-08-04 21:21:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 38882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698