Issue 44053002: Reduce co19-dartium.status and extend section condition in co19-co19.status and co19-runtime.status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44053002: Reduce co19-dartium.status and extend section condition in co19-co19.status and co19-runtime.status (Closed)

Created:
7 years, 1 month ago by kustermann

Modified:
7 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reduce co19-dartium.status and extend section condition in co19-co19.status and co19-runtime.status Most of the failures on dartium are common with the VM. TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29247

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -157 lines)			Patch
M	tests/co19/co19-co19.status	View	5 chunks	+41 lines, -36 lines	1 comment	Download
M	tests/co19/co19-dartium.status	View	3 chunks	+4 lines, -104 lines	1 comment	Download
M	tests/co19/co19-runtime.status	View	2 chunks	+18 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #1 manually as r29247 (presubmit successful).

7 years, 1 month ago (2013-10-25 12:15:10 UTC) #2

ricow1

7 years, 1 month ago (2013-10-25 14:05:04 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/44053002/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/44053002/diff/1/tests/co19/co19-co19.status#n...
tests/co19/co19-co19.status:45: [ $runtime == vm || $runtime == dartium ||
$compiler == dart2dart || $compiler == dart2js ]
could we change this to $compiler != analyzer?

https://codereview.chromium.org/44053002/diff/1/tests/co19/co19-dartium.status
File tests/co19/co19-dartium.status (right):

https://codereview.chromium.org/44053002/diff/1/tests/co19/co19-dartium.statu...
tests/co19/co19-dartium.status:6: *: Skip # running co19 tests on content_shell
would make our dartium cycle-times very long
Maybe we should remove this?

Expand Messages | Collapse Messages