Added sha256 sums for build outputs

Added sha256 sums for build outputs

BUG: https://code.google.com/p/dart/issues/detail?id=20355

R=kevmoo@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38971

[kaendfinger, 2014-08-06 00:59:25]

I finished this Code Review. Obviously I can't check to see if it works, so I
will need you guys to test.

[kevmoo, 2014-08-06 01:03:57]

Please see comments.

Moved Seth to CC and rico to reviewers.

This is Rico's world

https://codereview.chromium.org/440233005/diff/1/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/440233005/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:361: checksum_filename = '%s.sha256' % filename
should be .sha256sum everywhere

https://codereview.chromium.org/440233005/diff/1/tools/dartium/upload_steps.py
File tools/dartium/upload_steps.py (right):

https://codereview.chromium.org/440233005/diff/1/tools/dartium/upload_steps.p...
tools/dartium/upload_steps.py:211: local_sha256 =
bot_utils.CreateSha256ChecksumFile(local_path, mangled_filename)
long line -> we try to keep all lines <= 80 chars

https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py
File tools/signing_script.py (right):

https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py#newc...
tools/signing_script.py:138: sha256_zip_file = source_zip + '.sha256'
should be .sha256sum everywhere

https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py#newc...
tools/signing_script.py:145: run([GSUTIL, 'setacl', 'public-read', bucket +
'.sha256'])
should be .sha256sum everywhere

https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py#newc...
tools/signing_script.py:285: main()
Not sure if this deleted the trailing new line or not

All files should end in a new-line

[kaendfinger, 2014-08-06 01:12:35]

On 2014/08/06 01:03:57, kevmoo wrote:
> Please see comments.
> 
> Moved Seth to CC and rico to reviewers.
> 
> This is Rico's world
> 
> https://codereview.chromium.org/440233005/diff/1/tools/bots/bot_utils.py
> File tools/bots/bot_utils.py (right):
> 
>
https://codereview.chromium.org/440233005/diff/1/tools/bots/bot_utils.py#newc...
> tools/bots/bot_utils.py:361: checksum_filename = '%s.sha256' % filename
> should be .sha256sum everywhere
> 
> https://codereview.chromium.org/440233005/diff/1/tools/dartium/upload_steps.py
> File tools/dartium/upload_steps.py (right):
> 
>
https://codereview.chromium.org/440233005/diff/1/tools/dartium/upload_steps.p...
> tools/dartium/upload_steps.py:211: local_sha256 =
> bot_utils.CreateSha256ChecksumFile(local_path, mangled_filename)
> long line -> we try to keep all lines <= 80 chars
> 
> https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py
> File tools/signing_script.py (right):
> 
>
https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py#newc...
> tools/signing_script.py:138: sha256_zip_file = source_zip + '.sha256'
> should be .sha256sum everywhere
> 
>
https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py#newc...
> tools/signing_script.py:145: run([GSUTIL, 'setacl', 'public-read', bucket +
> '.sha256'])
> should be .sha256sum everywhere
> 
>
https://codereview.chromium.org/440233005/diff/1/tools/signing_script.py#newc...
> tools/signing_script.py:285: main()
> Not sure if this deleted the trailing new line or not
> 
> All files should end in a new-line

done

[kevmoo, 2014-08-06 01:18:23]

https://codereview.chromium.org/440233005/diff/20001/tools/dartium/upload_ste...
File tools/dartium/upload_steps.py (right):

https://codereview.chromium.org/440233005/diff/20001/tools/dartium/upload_ste...
tools/dartium/upload_steps.py:211: local_sha256 =
bot_utils.CreateSha256ChecksumFile(local_path, mangled_filename)
long line?

[kaendfinger, 2014-08-06 01:23:13]

On 2014/08/06 01:18:23, kevmoo wrote:
>
https://codereview.chromium.org/440233005/diff/20001/tools/dartium/upload_ste...
> File tools/dartium/upload_steps.py (right):
> 
>
https://codereview.chromium.org/440233005/diff/20001/tools/dartium/upload_ste...
> tools/dartium/upload_steps.py:211: local_sha256 =
> bot_utils.CreateSha256ChecksumFile(local_path, mangled_filename)
> long line?

done

[kevmoo, 2014-08-06 01:24:51]

On 2014/08/06 01:23:13, kaendfinger wrote:
> On 2014/08/06 01:18:23, kevmoo wrote:
> >
>
https://codereview.chromium.org/440233005/diff/20001/tools/dartium/upload_ste...
> > File tools/dartium/upload_steps.py (right):
> > 
> >
>
https://codereview.chromium.org/440233005/diff/20001/tools/dartium/upload_ste...
> > tools/dartium/upload_steps.py:211: local_sha256 =
> > bot_utils.CreateSha256ChecksumFile(local_path, mangled_filename)
> > long line?
> 
> done

LGTM, but waiting on Rico

[ricow1, 2014-08-06 06:49:35]

https://codereview.chromium.org/440233005/diff/40001/tools/dartium/upload_ste...
File tools/dartium/upload_steps.py (right):

https://codereview.chromium.org/440233005/diff/40001/tools/dartium/upload_ste...
tools/dartium/upload_steps.py:200: def UploadFile(local_path, remote_path,
create_md5sum=False):
create_md5 should be renamed create_checksum_files
This means also changing editor/build/build.py

[kaendfinger, 2014-08-06 21:50:27]

On 2014/08/06 06:49:35, ricow1 wrote:
>
https://codereview.chromium.org/440233005/diff/40001/tools/dartium/upload_ste...
> File tools/dartium/upload_steps.py (right):
> 
>
https://codereview.chromium.org/440233005/diff/40001/tools/dartium/upload_ste...
> tools/dartium/upload_steps.py:200: def UploadFile(local_path, remote_path,
> create_md5sum=False):
> create_md5 should be renamed create_checksum_files
> This means also changing editor/build/build.py

done

[ricow1, 2014-08-07 09:30:23]

Committed patchset #4 manually as 38971 (presubmit successful).