Issue 439713006: Reland r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439713006: Reland r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime" (Closed)

Created:
6 years, 4 months ago by Bill Hesse

Modified:
6 years, 4 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reland r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime" This was reverted in r38002, because it didn't seem needed. It now looks like it will make the builder more stable. Original CL: https://codereview.chromium.org/363323002/ TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38866

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View		5 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Committed patchset #1 manually as 38866 (presubmit successful).

6 years, 4 months ago (2014-08-04 16:25:55 UTC) #2

Bill Hesse

6 years, 4 months ago (2014-08-04 18:53:13 UTC) #3

Message was sent while issue was closed.

On 2014/08/04 16:25:55, Bill Hesse wrote:
> Committed patchset #1 manually as 38866 (presubmit successful).

Well, that didn't work out well.  test.dart is now exiting after only running a
subset of the tests, and there are failures showing up, consistently, in 3 tests
that weren't failing before.  Previously, all of the co19 tests, which are the
only ones now reached, were passing.  I will leave this as is until tomorrow.

Expand Messages | Collapse Messages