Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 439513002: Fix js/null_test to run also in CSP mode (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
ricow1, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix js/null_test to run also in CSP mode R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38909

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M tests/lib/js/null_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/js/null_test.html View 1 chunk +1 line, -4 lines 0 comments Download
A + tests/lib/js/null_test.js View 1 1 chunk +3 lines, -9 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-01 17:46:25 UTC) #1
Siggi Cherem (dart-lang)
ping
6 years, 4 months ago (2014-08-05 20:31:46 UTC) #2
sra1
lgtm
6 years, 4 months ago (2014-08-05 21:25:45 UTC) #3
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-05 21:46:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 38909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698