Issue 438953002: Ignore deferred loading from dart backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438953002: Ignore deferred loading from dart backend. (Closed)

Created:
6 years, 4 months ago by sigurdm

Modified:
5 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore deferred loading from dart backend. A warning will be printed instead of an error. BUG=20109 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=38849

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/deferred_load.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/438953002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/438953002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode1179 sdk/lib/_internal/compiler/implementation/warnings.dart:1179: "Will not split the output."); "Will .. output" ...

6 years, 4 months ago (2014-08-04 07:34:53 UTC) #2

sigurdm

6 years, 4 months ago (2014-08-04 08:18:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 38849 (presubmit successful).

Expand Messages | Collapse Messages

Issue 438953002: Ignore deferred loading from dart backend. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages