Issue 438773002: "Reverting 38798"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438773002: "Reverting 38798" (Closed)

Created:
6 years, 4 months ago by Bob Nystrom

Modified:
6 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

"Reverting 38798" R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=38811

Patch Set 1 #

Created: 6 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -724 lines)
M	sdk/lib/_internal/pub/lib/src/command/global_activate.dart	View	1 chunk	+17 lines, -46 lines	0 comments
M	sdk/lib/_internal/pub/lib/src/command/global_deactivate.dart	View	2 chunks	+1 line, -5 lines	0 comments
M	sdk/lib/_internal/pub/lib/src/global_packages.dart	View	6 chunks	+65 lines, -182 lines	0 comments
M	sdk/lib/_internal/pub/lib/src/source/path.dart	View	5 chunks	+7 lines, -18 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/activate_hosted_after_local_test.dart	View	1 chunk	+0 lines, -41 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/activate_path_after_hosted_test.dart	View	1 chunk	+0 lines, -36 lines	0 comments
M	sdk/lib/_internal/pub/test/global/activate/bad_version_test.dart	View	1 chunk	+2 lines, -4 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/constraint_with_path_test.dart	View	1 chunk	+0 lines, -24 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/does_not_install_dependencies_for_path_test.dart	View	1 chunk	+0 lines, -25 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/git_package_missing_ref_test.dart	View	1 chunk	+0 lines, -25 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/git_package_test.dart	View	1 chunk	+0 lines, -25 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/hosted_package_test.dart	View	1 chunk	+0 lines, -32 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/installs_dependencies_for_git_package_test.dart	View	1 chunk	+0 lines, -35 lines	0 comments
M	sdk/lib/_internal/pub/test/global/activate/missing_package_arg_test.dart	View	1 chunk	+4 lines, -5 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/no_package_at_path_test.dart	View	1 chunk	+0 lines, -18 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/path_does_not_exist_test.dart	View	1 chunk	+0 lines, -14 lines	0 comments
D	sdk/lib/_internal/pub/test/global/activate/path_package_test.dart	View	1 chunk	+0 lines, -21 lines	0 comments
A +	sdk/lib/_internal/pub/test/global/activate/uncached_package_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments
M	sdk/lib/_internal/pub/test/global/activate/unexpected_arguments_test.dart	View	1 chunk	+4 lines, -5 lines	0 comments
A +	sdk/lib/_internal/pub/test/global/deactivate/deactivate_package_test.dart	View	1 chunk	+1 line, -1 line	0 comments
D	sdk/lib/_internal/pub/test/global/deactivate/path_package_test.dart	View	1 chunk	+0 lines, -27 lines	0 comments
D	sdk/lib/_internal/pub/test/global/deactivate/remote_package_test.dart	View	1 chunk	+0 lines, -19 lines	0 comments
M	sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments
D	sdk/lib/_internal/pub/test/global/run/gets_first_if_needed_test.dart	View	1 chunk	+0 lines, -35 lines	0 comments
M	sdk/lib/_internal/pub/test/global/run/implicit_executable_name_test.dart	View	1 chunk	+1 line, -0 lines	0 comments
D	sdk/lib/_internal/pub/test/global/run/missing_path_package_test.dart	View	1 chunk	+0 lines, -31 lines	0 comments
M	sdk/lib/_internal/pub/test/global/run/nonexistent_script_test.dart	View	1 chunk	+1 line, -1 line	0 comments
D	sdk/lib/_internal/pub/test/global/run/reflects_changes_to_local_package_test.dart	View	1 chunk	+0 lines, -26 lines	0 comments
D	sdk/lib/_internal/pub/test/global/run/runs_local_script_test.dart	View	1 chunk	+0 lines, -24 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Argh, accidentally committed the wrong branch! Sorry. :(

6 years, 4 months ago (2014-07-31 22:24:18 UTC) #1

Bob Nystrom

6 years, 4 months ago (2014-07-31 23:53:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38811 (presubmit successful).

Expand Messages | Collapse Messages