Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 438753002: Ignore 'dynamic' and 'void' elements in the occurrences computer too. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ignore 'dynamic' and 'void' elements in the occurrences computer too. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 2 chunks +45 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-07-31 22:18:58 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-07-31 22:55:19 UTC) #2
scheglov
6 years, 4 months ago (2014-07-31 23:48:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698