Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 438503003: Fix js test for firefox now that null becomes 'null' and not 'undefined' (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, justinfagnani
Visibility:
Public.

Description

Fix js test for firefox now that null becomes 'null' and not 'undefined' R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
This fixes the test failure after my other change to dart:js.
6 years, 4 months ago (2014-08-01 02:11:21 UTC) #1
sra1
lgtm
6 years, 4 months ago (2014-08-01 02:15:00 UTC) #2
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-01 02:16:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 38821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698