Issue 438473002: pkg/matcher: refactored code around data-structure vs execution-based matchers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438473002: pkg/matcher: refactored code around data-structure vs execution-based matchers (Closed)

Created:
6 years, 4 months ago by kevmoo

Modified:
6 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/matcher: refactored code around data-structure vs execution-based matchers Also fixed a spelling error. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38807

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+351 lines, -287 lines)			Patch
M	pkg/matcher/CHANGELOG.md	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/matcher/lib/matcher.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/matcher/lib/src/core_matchers.dart	View	3 chunks	+1 line, -104 lines	0 comments	Download
M	pkg/matcher/lib/src/error_matchers.dart	View	11 chunks	+0 lines, -35 lines	0 comments	Download
M	pkg/matcher/lib/src/expect.dart	View	3 chunks	+26 lines, -21 lines	0 comments	Download
M	pkg/matcher/lib/src/future_matchers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/matcher/lib/src/interfaces.dart	View	3 chunks	+1 line, -28 lines	0 comments	Download
M	pkg/matcher/lib/src/iterable_matchers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/matcher/lib/src/map_matchers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/matcher/lib/src/operator_matchers.dart	View	3 chunks	+16 lines, -36 lines	0 comments	Download
A	pkg/matcher/lib/src/throws_matcher.dart	View	1 chunk	+113 lines, -0 lines	0 comments	Download
A	pkg/matcher/lib/src/throws_matchers.dart	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	pkg/matcher/lib/src/util.dart	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	pkg/matcher/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/matcher/test/core_matchers_test.dart	View	2 chunks	+0 lines, -59 lines	0 comments	Download
M	pkg/matcher/test/operator_matchers_test.dart	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	pkg/matcher/test/throws_matchers_test.dart	View	1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

I'm starting to isolate code that relies on static state (async wrapper, etc) looking to ...

6 years, 4 months ago (2014-07-31 04:27:14 UTC) #1

kevmoo

6 years, 4 months ago (2014-07-31 22:51:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38807 (presubmit successful).

Expand Messages | Collapse Messages