Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 438453002: Port and test more assists. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1468 lines, -551 lines) Patch
M pkg/analysis_services/lib/correction/assist.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analysis_services/lib/src/correction/assist.dart View 15 chunks +588 lines, -549 lines 2 comments Download
M pkg/analysis_services/lib/src/correction/source_range.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analysis_services/test/correction/assist_test.dart View 1 chunk +867 lines, -0 lines 0 comments Download
M pkg/analysis_testing/lib/mock_sdk.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-07-31 03:40:13 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/438453002/diff/1/pkg/analysis_services/lib/src/correction/assist.dart File pkg/analysis_services/lib/src/correction/assist.dart (right): https://codereview.chromium.org/438453002/diff/1/pkg/analysis_services/lib/src/correction/assist.dart#newcode265 pkg/analysis_services/lib/src/correction/assist.dart:265: AstNode bodyParent = body.parent; You know I don't ...
6 years, 4 months ago (2014-07-31 13:24:58 UTC) #2
scheglov
https://codereview.chromium.org/438453002/diff/1/pkg/analysis_services/lib/src/correction/assist.dart File pkg/analysis_services/lib/src/correction/assist.dart (right): https://codereview.chromium.org/438453002/diff/1/pkg/analysis_services/lib/src/correction/assist.dart#newcode265 pkg/analysis_services/lib/src/correction/assist.dart:265: AstNode bodyParent = body.parent; On 2014/07/31 13:24:58, Brian Wilkerson ...
6 years, 4 months ago (2014-07-31 16:09:03 UTC) #3
scheglov
6 years, 4 months ago (2014-07-31 16:09:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698