Issue 438303002: Revert "Add Uri.replace which creates a new Uri with the same fields as the original, but with some…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438303002: Revert "Add Uri.replace which creates a new Uri with the same fields as the original, but with some… (Closed)

Created:
6 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 4 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Add Uri.replace which creates a new Uri with the same fields as the original, but with some fields replaced by the user." Code has gone stale since first uploaded. Committed: https://code.google.com/p/dart/source/detail?r=38895

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -155 lines)			Patch
	M	sdk/lib/core/uri.dart	View		1 chunk	+0 lines, -95 lines	0 comments	Download
	M	tests/corelib/uri_test.dart	View		2 chunks	+0 lines, -60 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as 38895 (presubmit successful).

6 years, 4 months ago (2014-08-05 11:13:29 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages