Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 437813003: Add regression test for issue 20074. (Closed)

Created:
6 years, 4 months ago by Johnni Winther
Modified:
6 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add regression test for issue 20074. Issue solved for dart2js in r38847. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=38860

Patch Set 1 #

Patch Set 2 : Fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/language/regress_20074_test.dart View 1 1 chunk +8 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
6 years, 4 months ago (2014-08-04 09:55:37 UTC) #1
karlklose
LGTM.
6 years, 4 months ago (2014-08-04 10:54:59 UTC) #2
Johnni Winther
6 years, 4 months ago (2014-08-04 14:31:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698