Issue 43773004: dart:platform | Remove isWindows, isLinux, isAndroid, isMacOS from dart:platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43773004: dart:platform | Remove isWindows, isLinux, isAndroid, isMacOS from dart:platform. (Closed)

Created:
7 years, 1 month ago by Bill Hesse

Modified:
7 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart:platform | Remove isWindows, isLinux, isAndroid, isMacOS from dart:platform. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=29268

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -46 lines)			Patch
M	runtime/bin/builtin.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/lib/platform_patch.dart	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	sdk/lib/_internal/lib/platform_patch.dart	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/platform/platform.dart	View		2 chunks	+4 lines, -22 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/lib/platform/operating_system_test.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/lib/platform/path_separator_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/platform/uri_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

Also added status file entries for dart2dart, which changes the script name and the package ...

7 years, 1 month ago (2013-10-25 17:47:42 UTC) #1

Bill Hesse

7 years, 1 month ago (2013-10-25 18:26:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29268 (presubmit successful).