Port and test more assists.

Port and test more assists.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38881

[Brian Wilkerson, 2014-08-04 21:13:20]

LGTM

https://codereview.chromium.org/437323004/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/assist.dart (right):

https://codereview.chromium.org/437323004/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/assist.dart:587:
_addInsertEdit(importDirective.end - 1, sb.toString());
I suspect 'sb' was once an abbreviation of 'StringBuffer', but now it's just a
string, so consider
(a) naming it 'showCombinator' and
(b) not invoking 'toString()'

[scheglov, 2014-08-04 21:18:55]

https://codereview.chromium.org/437323004/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/assist.dart (right):

https://codereview.chromium.org/437323004/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/assist.dart:587:
_addInsertEdit(importDirective.end - 1, sb.toString());
On 2014/08/04 21:13:20, Brian Wilkerson wrote:
> I suspect 'sb' was once an abbreviation of 'StringBuffer', but now it's just a
> string, so consider
> (a) naming it 'showCombinator' and
> (b) not invoking 'toString()'

Done.

[scheglov, 2014-08-04 21:19:17]

Committed patchset #2 manually as 38881 (presubmit successful).