Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 436463002: First unit test using service lib. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

First unit test using service lib. Add symlink to allow using observatory package from tests. Add simple test of allocation stats. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38788

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A tests/standalone/vmservice/allocations_script.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download
A tests/standalone/vmservice/allocations_test.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 4 months ago (2014-07-30 23:35:34 UTC) #1
koda
Rietveld doesn't show the added symlink. Hope it works... Here's what svn diff shows: Index: ...
6 years, 4 months ago (2014-07-30 23:42:18 UTC) #2
Cutch
This is great. Much better way of writing unit tests. lgtm
6 years, 4 months ago (2014-07-31 15:38:19 UTC) #3
koda
6 years, 4 months ago (2014-07-31 16:36:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698