Issue 435553002: Improve utf8 decoding of single-char bytes, by isolating the loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 435553002: Improve utf8 decoding of single-char bytes, by isolating the loop. (Closed)

Created:
6 years, 4 months ago by Anders Johnsen

Modified:
6 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, floitsch, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve utf8 decoding of single-char bytes, by isolating the loop. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=38776

Patch Set 2 : Revert debug change. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
	M	sdk/lib/convert/utf.dart	View	1	5 chunks	+17 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

I see a ~3x speedup in one case (actually more, due to GC overhead).

6 years, 4 months ago (2014-07-31 09:26:57 UTC) #1

Florian Schneider

lgtm https://codereview.chromium.org/435553002/diff/1/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/435553002/diff/1/sdk/lib/convert/utf.dart#newcode440 sdk/lib/convert/utf.dart:440: var str = new String.fromCharCodes(codeUnits); Why this change?

6 years, 4 months ago (2014-07-31 11:19:49 UTC) #2

Anders Johnsen

https://codereview.chromium.org/435553002/diff/1/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/435553002/diff/1/sdk/lib/convert/utf.dart#newcode440 sdk/lib/convert/utf.dart:440: var str = new String.fromCharCodes(codeUnits); On 2014/07/31 11:19:49, Florian ...

6 years, 4 months ago (2014-07-31 12:23:03 UTC) #3

Anders Johnsen

6 years, 4 months ago (2014-07-31 12:23:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38776 (presubmit successful).

Expand Messages | Collapse Messages

Issue 435553002: Improve utf8 decoding of single-char bytes, by isolating the loop. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Revert debug change. #

Messages