Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 43483004: Remove the reply port form the native isolate handler (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
Reviewers:
Bill Hesse, floitsch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

Remove the reply port form the native isolate handler The handler function for a native isolate no longer gets an explicit reply port. Instead the reply port must be sent as part of the message if required. The Dart_CObject structure now exposes the send ports in a message to a native isolate. R=asiva@google.com, floitsch@google.com, whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29418

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated to new isolate API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -62 lines) Patch
M runtime/bin/dartutils.h View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/bin/io_service.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M runtime/bin/io_service_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_native_api.h View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 3 chunks +47 lines, -30 lines 0 comments Download
M runtime/vm/native_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/sample_extension/sample_asynchronous_extension.dart View 1 1 chunk +12 lines, -9 lines 0 comments Download
M samples/sample_extension/sample_extension.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-10-25 14:12:14 UTC) #1
floitsch
DBC. https://codereview.chromium.org/43483004/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/43483004/diff/1/runtime/vm/dart_api_impl_test.cc#newcode5785 runtime/vm/dart_api_impl_test.cc:5785: " var replyPort = receivePort.toSendPort();\n" This will have ...
7 years, 1 month ago (2013-10-25 18:04:58 UTC) #2
siva
LGTM once comments from Florian are addressed.
7 years, 1 month ago (2013-10-28 02:13:42 UTC) #3
Søren Gjesse
https://codereview.chromium.org/43483004/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/43483004/diff/1/runtime/vm/dart_api_impl_test.cc#newcode5785 runtime/vm/dart_api_impl_test.cc:5785: " var replyPort = receivePort.toSendPort();\n" On 2013/10/25 18:04:58, floitsch ...
7 years, 1 month ago (2013-10-29 07:42:57 UTC) #4
Søren Gjesse
7 years, 1 month ago (2013-10-29 08:45:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698