Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 433153005: Skip some slow analysis server tests on ARM and MIPS simulators. (Closed)

Created:
6 years, 4 months ago by Florian Schneider
Modified:
6 years, 4 months ago
Reviewers:
Bill Hesse, Paul Berry
CC:
reviews_dartlang.org, Paul Berry
Visibility:
Public.

Description

Skip some slow analysis server tests on ARM and MIPS simulators. R=paulberry@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=38858

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Florian Schneider
These are not run on the buildbot, but are consistently timing out on my machine.
6 years, 4 months ago (2014-08-04 12:35:01 UTC) #1
Paul Berry
lgtm I would also be fine with skipping the whole "integration" directory on these platforms. ...
6 years, 4 months ago (2014-08-04 13:03:26 UTC) #2
Bill Hesse
lgtm
6 years, 4 months ago (2014-08-04 13:22:11 UTC) #3
Florian Schneider
Committed patchset #2 manually as r38858 (presubmit successful).
6 years, 4 months ago (2014-08-04 14:00:59 UTC) #4
Florian Schneider
6 years, 4 months ago (2014-08-04 14:49:11 UTC) #5
Message was sent while issue was closed.
On 2014/08/04 13:03:26, Paul Berry wrote:
> lgtm
> 
> I would also be fine with skipping the whole "integration" directory on these
> platforms.  (We are planning on adding more integration tests in the coming
> weeks, so it would avoid future headaches).

Sounds good. I skipped the whole directory for now.

Powered by Google App Engine
This is Rietveld 408576698