Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 432293002: Mark broken / timing out tests as skip (Closed)

Created:
6 years, 4 months ago by vsm
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
vsm
6 years, 4 months ago (2014-08-01 07:59:38 UTC) #1
vsm
Committed patchset #1 manually as 38824 (presubmit successful).
6 years, 4 months ago (2014-08-01 07:59:53 UTC) #2
ricow1
lgtm
6 years, 4 months ago (2014-08-01 08:00:30 UTC) #3
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-01 17:09:46 UTC) #4
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/432293002/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/432293002/diff/1/pkg/pkg.status#newcode27
pkg/pkg.status:27: polymer/e2e_test/experimental_boot/test/import_test: Skip #
Issue 20307 (Timing out)
it might be better to mark it Timeout instead?

Powered by Google App Engine
This is Rietveld 408576698