Issue 432183003: Fix dart2js int double test failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 432183003: Fix dart2js int double test failure (Closed)

Created:
6 years, 4 months ago by Cutch

Modified:
6 years, 4 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart2js int double test failure BUG= Committed: https://code.google.com/p/dart/source/detail?r=38816

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -14 lines)			Patch
M	tests/lib/lib.status	View	1 chunk	+3 lines, -0 lines	1 comment	Download
A +	tests/lib/profiler/metrics_num_test.dart	View	1 chunk	+12 lines, -9 lines	1 comment	Download
M	tests/lib/profiler/metrics_test.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r38816 (presubmit successful).

6 years, 4 months ago (2014-08-01 00:46:37 UTC) #2

sra1

6 years, 4 months ago (2014-08-01 00:53:22 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/432183003/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/432183003/diff/1/tests/lib/lib.status#newcode322
tests/lib/lib.status:322: profiler/metrics_num_test: Skip
Add comment to say this is due to dart2js not keeping int and double distinct.

https://codereview.chromium.org/432183003/diff/1/tests/lib/profiler/metrics_n...
File tests/lib/profiler/metrics_num_test.dart (right):

https://codereview.chromium.org/432183003/diff/1/tests/lib/profiler/metrics_n...
tests/lib/profiler/metrics_num_test.dart:11: // max is not a double
I'm immediately sure what max is.
Maybe change these comments to say:
// `max` argument is not double.

Expand Messages | Collapse Messages