Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 431593002: Allow analysis server integration tests to run without package root. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow analysis server integration tests to run without package root. Since the analysis server will periodically be released via pub, some users may try running integration tests using the a local "packages" directory rather than specifying a package root. When this happens, avoid sending an empty "--package-root=" option to the VM. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=38731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-07-30 13:02:53 UTC) #1
danrubel
LGTM. Thanks!
6 years, 4 months ago (2014-07-30 13:21:24 UTC) #2
Paul Berry
6 years, 4 months ago (2014-07-30 13:41:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38731 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698