Issue 431443003: Exposing code_transformer's Resolvers options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431443003: Exposing code_transformer's Resolvers options (Closed)

Created:
6 years, 4 months ago by blois

Modified:
6 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, salsburyd_google.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Exposing code_transformer's Resolvers options BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38713

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	pkg/code_transformers/lib/src/resolvers.dart	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
	M	pkg/code_transformers/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/431443003/diff/1/pkg/code_transformers/lib/src/resolvers.dart File pkg/code_transformers/lib/src/resolvers.dart (right): https://codereview.chromium.org/431443003/diff/1/pkg/code_transformers/lib/src/resolvers.dart#newcode44 pkg/code_transformers/lib/src/resolvers.dart:44: return new Resolvers.fromSdk(sdk, sdk.resolver); do we need it ...

6 years, 4 months ago (2014-07-29 23:10:42 UTC) #2

blois

https://codereview.chromium.org/431443003/diff/1/pkg/code_transformers/lib/src/resolvers.dart File pkg/code_transformers/lib/src/resolvers.dart (right): https://codereview.chromium.org/431443003/diff/1/pkg/code_transformers/lib/src/resolvers.dart#newcode44 pkg/code_transformers/lib/src/resolvers.dart:44: return new Resolvers.fromSdk(sdk, sdk.resolver); On 2014/07/29 23:10:41, Siggi Cherem ...

6 years, 4 months ago (2014-07-29 23:27:41 UTC) #3

blois

6 years, 4 months ago (2014-07-29 23:31:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38713 (presubmit successful).

Expand Messages | Collapse Messages

Issue 431443003: Exposing code_transformer's Resolvers options (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages