Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 43143002: Avoid sending needless data between isolates in "pub serve" and "pub build" (Closed)

Created:
7 years, 2 months ago by nweiz
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Avoid sending needless data between isolates in "pub serve" and "pub build" Previously when passing barback assets between isolates, pub would eagerly send the entire contents of the asset. Now it waits to do so until some code actually subscribes to the asset's data stream. BUG=14430 R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=29408

Patch Set 1 #

Patch Set 2 : Merge with bleeding edge #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -72 lines) Patch
M pkg/barback/lib/src/stream_replayer.dart View 3 chunks +32 lines, -20 lines 0 comments Download
M pkg/barback/test/stream_replayer_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 5 chunks +113 lines, -52 lines 2 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
7 years, 2 months ago (2013-10-25 03:49:45 UTC) #1
Bob Nystrom
LGTM!
7 years, 1 month ago (2013-10-25 23:44:18 UTC) #2
nweiz
I just merged this with the recent isolate changes and there was rather a lot ...
7 years, 1 month ago (2013-10-28 23:39:49 UTC) #3
Bob Nystrom
Couple of questions, but LGTM assuming I have the right answers. https://codereview.chromium.org/43143002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): ...
7 years, 1 month ago (2013-10-28 23:52:49 UTC) #4
nweiz
https://codereview.chromium.org/43143002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/43143002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode603 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:603: var receivePort = new ReceivePort(); On 2013/10/28 23:52:49, Bob ...
7 years, 1 month ago (2013-10-29 00:15:55 UTC) #5
nweiz
7 years, 1 month ago (2013-10-29 00:18:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r29408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698