Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 431263002: Address comments on c_frame_pointers CL (Closed)

Created:
6 years, 4 months ago by Cutch
Modified:
6 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Address comments on c_frame_pointers CL R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38990

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M tools/gyp/configurations_make.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
6 years, 4 months ago (2014-08-01 01:13:54 UTC) #1
Ivan Posva
LGTM -ip
6 years, 4 months ago (2014-08-05 21:28:53 UTC) #2
Cutch
6 years, 4 months ago (2014-08-07 15:52:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 38990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698